Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRU2024 #188

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

SRU2024 #188

wants to merge 19 commits into from

Conversation

zubri
Copy link
Member

@zubri zubri commented Apr 24, 2024

Summary by CodeRabbit

  • New Features

    • Introduced FieldEnum for enhanced field name handling.
    • Added IBAN validation for Egypt's local account structure.
    • Updated for the 2024 SWIFT Standard release.
  • Bug Fixes

    • Restored a deprecated method in the MT210 class.
  • Security Improvements

    • Implemented security enhancements based on CodeQL recommendations.
  • Documentation

    • Updated changelog to reflect version changes and new features.
  • Chores

    • Updated dependencies for improved compatibility and performance.

Copy link

coderabbitai bot commented May 23, 2024

📝 Walkthrough

Walkthrough

The pull request introduces updates to the Prowide Core library, moving from version 9.4.x to 9.5.x. Key enhancements include the addition of a FieldEnum for field names, security improvements based on CodeQL recommendations, and IBAN validation for Egypt. The MT210 class has a deprecated method restored. Version 9.5.0 features updates for the SWIFT Standard release for 2024 and dependency updates to ensure compatibility with the latest library versions. The build.gradle file reflects these changes with updated dependencies and configuration adjustments.

Changes

File(s) Change Summary
CHANGELOG.md Updated to reflect changes in Prowide Core library, including version updates and new features.
src/main/java/com/prowidesoftware/swift/... Added FieldEnum and updated validateIBAN() method in IBANValidator.
build.gradle Updated dependencies (commons-lang3, gson, junit-jupiter, assertj-core, xmlunit-core) and modified versioning and testing configurations.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ProwideCore
    participant IBANValidator

    User->>ProwideCore: Request IBAN validation
    ProwideCore->>IBANValidator: Validate IBAN
    IBANValidator-->>ProwideCore: Return validation result
    ProwideCore-->>User: Send validation result
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

zubri and others added 8 commits May 23, 2024 18:19
#194)

* CU-86b1g1mye_SRU2024_Generar-un-enum-de-FieldNames-para-validar-que-el-Field-exista

* CU-86b1g1mye_SRU2024_Generar-un-enum-de-FieldNames-para-validar-que-el-Field-exista

---------

Co-authored-by: Sebastian Zubrinic <sebastian@prowidesoftware.com>
…pos (#201)

* CU-86b14j4e0_SRU2024_check-code-security-reports-at-GitHub-for-all-repos

* CU-86b14j4e0_SRU2024_check-code-security-reports-at-GitHub-for-all-repos

* CU-86b14j4e0_SRU2024_check-code-security-reports-at-GitHub-for-all-repos
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between ef1ad32 and 7db754e.

⛔ Files ignored due to path filters (298)
  • src/generated/java/com/prowidesoftware/swift/SchemeConstantsA.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/SchemeConstantsB.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/SchemeConstantsE.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/SchemeConstantsF.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/SchemeConstantsH.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/SchemeConstantsM.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/SchemeConstantsN.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/SchemeConstantsO.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/SchemeConstantsP.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/SchemeConstantsR.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field101.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field102.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field103.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field104.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field105.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field106.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field107.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field108.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field109.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field110.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field111.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field113.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field114.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field115.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field116.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field117.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field118.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field119.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field11A.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field11R.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field11S.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field12.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field120.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field121.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field122.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field123.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field124.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field125.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field126.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field127.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field128.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field129.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field12A.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field12B.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field12C.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field12D.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field12E.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field12F.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field12G.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field130.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field132.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field133.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field134.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field135.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field136.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field137.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field13A.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field13B.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field13C.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field13D.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field13J.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field13K.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field140.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field141.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field142.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field143.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field144.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14A.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14B.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14C.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14D.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14E.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14F.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14G.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14H.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14J.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14K.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14L.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14M.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14N.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14O.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14P.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14Q.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14R.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field14S.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field151.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field152.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field153.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15A.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15B.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15C.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15D.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15E.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15F.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15G.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15H.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15I.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15J.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15K.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15L.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15M.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15N.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15O.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field15P.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field165.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field16A.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field16C.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field16D.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field16R.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field16S.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field16W.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field171.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field172.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field173.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field174.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field175.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field177.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field179.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17A.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17B.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17C.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17E.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17F.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17G.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17H.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17I.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17L.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17M.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17N.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17O.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17P.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17Q.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17R.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17S.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17T.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17U.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17V.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17W.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17X.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17Y.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field17Z.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field18A.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field18B.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field18C.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field18D.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field19.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field199.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field19A.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field19B.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field19C.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field19Y.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field19Z.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field20.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field202.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field203.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field204.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field206.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field208.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field209.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field20C.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field20D.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field20U.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field21.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field21A.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field21B.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field21C.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field21D.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field21E.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field21F.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field21G.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field21H.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field21N.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field21P.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field21R.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22A.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22B.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22C.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22D.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22E.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22F.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22G.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22H.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22K.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22L.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22M.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22N.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22P.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22Q.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22R.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22S.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22T.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22U.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22V.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22W.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22X.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22Y.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field22Z.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field23.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field23A.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field23B.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field23C.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field23D.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field23E.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field23F.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field23G.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field23H.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field23R.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field23S.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field23X.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field242.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field243.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field24B.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field24D.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field24E.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field24G.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field25.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field251.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field252.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field253.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field254.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field255.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field256.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field257.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field258.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field259.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field25A.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field25D.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field25P.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field260.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field263.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field264.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field26A.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field26B.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field26C.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field26D.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field26E.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field26F.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field26H.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field26K.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field26T.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field27.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field270.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field271.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field272.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field28.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field280.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field281.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field28C.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field28D.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field28E.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field29A.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field29B.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field29E.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field29H.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field29I.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field29J.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field29L.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field29M.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field29N.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field29O.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field29Q.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field29W.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field301.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field302.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field303.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field304.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field305.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field307.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30F.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30G.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30H.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30I.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30J.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30K.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30M.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30N.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30P.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30Q.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30S.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30T.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30U.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30V.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30X.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30Y.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field30Z.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field311.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field312.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field313.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field31C.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field31D.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field31E.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field31F.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field31G.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field31L.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field31P.java is excluded by !**/generated/**
  • src/generated/java/com/prowidesoftware/swift/model/field/Field31R.java is excluded by !**/generated/**
📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • build.gradle (3 hunks)
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md

3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


5-5: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


8-8: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


9-9: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


12-12: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


13-13: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


14-14: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


15-15: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


7-7: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


11-11: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


4-4: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


8-8: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


12-12: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


13-13: null
Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (11)
build.gradle (5)

27-27: LGTM: SRU variable updated for 2024

The update of the SRU variable to 'SRU2024' is in line with the PR objectives. This change reflects the annual SWIFT Release Update.

Please ensure that this change is consistently applied throughout the build file and doesn't cause any unintended side effects in version numbers or other configurations.


56-56: LGTM: commons-lang3 dependency updated

The update of commons-lang3 from 3.12.0 to 3.14.0 is a good practice to keep dependencies current.

Please review the changelog for commons-lang3 3.14.0 to ensure there are no breaking changes that might affect the project.


57-57: LGTM: gson dependency updated

The update of gson from 2.9.0 to 2.11.0 is a good practice to keep dependencies current.

Please review the changelog for gson 2.11.0 to ensure there are no breaking changes that might affect the project.


Line range hint 1-379: Summary of changes and potential impact

The changes in this build.gradle file are primarily focused on:

  1. Updating the SRU (SWIFT Release Update) version to 2024
  2. Updating various dependencies to their latest versions

These changes align with the PR objectives and are generally good practices for maintaining the project. However, there are a few points to consider:

  1. The SRU update might affect version numbers and other configurations in the project. Ensure this change is consistently applied across the codebase.
  2. The dependency updates, while beneficial, may introduce breaking changes. It's crucial to review the changelogs of each updated dependency and test thoroughly.
  3. There's an inconsistency in the xmlunit dependency versions that should be addressed.

To ensure these changes don't introduce any issues:

  1. Run a full build and test suite to catch any potential compatibility issues.
  2. Review the project's CI/CD pipeline results after these changes.
  3. If possible, perform a staged rollout or additional testing in a pre-production environment.

65-69: ⚠️ Potential issue

LGTM: Test dependencies updated, but note xmlunit version inconsistency

The updates to junit-jupiter, assertj-core, and xmlunit-core are good practices to keep dependencies current.

Please review the changelogs for junit-jupiter 5.10.2, assertj-core 3.25.3, and xmlunit-core 2.10.0 to ensure there are no breaking changes that might affect the project's tests.

There's an inconsistency in the xmlunit dependency versions:

  • xmlunit-core is updated to 2.10.0
  • xmlunit-matchers and xmlunit-assertj remain at 2.9.0

Consider updating all xmlunit dependencies to the same version to ensure compatibility and avoid potential issues.

CHANGELOG.md (6)

3-5: New features and improvements in the SNAPSHOT version

The SNAPSHOT version 9.5.2 introduces two significant changes:

  1. A new FieldEnum with all available field names, which should improve field handling and validation.
  2. Code security improvements based on CodeQL recommendations, indicating a focus on enhancing the library's security.

These changes demonstrate ongoing development and a commitment to both feature expansion and security.

🧰 Tools
🪛 Markdownlint

3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


5-5: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


4-4: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


7-10: Version 9.5.1 updates

Version 9.5.1, dated June 2024, includes two notable changes:

  1. Addition of IBAN validation for Egypt's local account structure (PW-1913), expanding the library's geographical coverage.
  2. Restoration of a deprecated method in the MT210 class, which might be for backward compatibility reasons.

These updates show continued improvement in international banking support and maintenance of existing functionality.

🧰 Tools
🪛 Markdownlint

8-8: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


9-9: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


7-7: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


8-8: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


11-15: Significant updates in version 9.5.0

Version 9.5.0, dated May 2024, brings several important updates:

  1. SWIFT Standard release update for 2024, to be live on November 16, 2025.
  2. Annual revision of the deprecation phase, with a link to the deprecation policy.
  3. Dependency updates: commons-lang3 to 3.14.0 and gson to 2.11.0.

These changes reflect the library's alignment with the latest SWIFT standards and its commitment to using up-to-date dependencies. The early preparation for the 2025 SWIFT update is noteworthy.

🧰 Tools
🪛 Markdownlint

12-12: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


13-13: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


14-14: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


15-15: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


11-11: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


12-12: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


13-13: null
Bare URL used

(MD034, no-bare-urls)


Line range hint 17-85: Summary of changes in versions 9.4.0 to 9.4.16

This section of the changelog covers multiple minor versions from 9.4.0 to 9.4.16, showcasing a series of incremental improvements and bug fixes:

  1. Field-specific updates: Various fields (e.g., 37K, 59F, 29O, 30I, 14[H,K,L,M,N,O], 29J, 31R, 24G, 44J) received fixes or enhancements.
  2. New features: Added support for DistinguishedName with Builder, new getters for specific MTs, and JSON-related improvements.
  3. Performance enhancements: Fixed stack overflow issues and improved parsing efficiency.
  4. API improvements: Added new methods to SwiftTagListBlock, enhanced existing APIs, and improved consistency in method naming.
  5. Bug fixes: Addressed issues in parsing, validation patterns, and specific field behaviors.
  6. Dependency updates: Updated to SWIFT Standard release 2023 and revised the deprecation phase.

These changes demonstrate a commitment to maintaining and improving the library, addressing user needs, and keeping up with SWIFT standards.

🧰 Tools
🪛 LanguageTool

[typographical] ~17-~17: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...ncy update: gson -> 2.11.0' #### 9.4.16 - May 2024 * (PW-1862) Added NarrativeFr...

(DASH_RULE)

🪛 Markdownlint

3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


5-5: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


8-8: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


9-9: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


12-12: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


13-13: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


14-14: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


15-15: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


18-18: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


7-7: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


11-11: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


17-17: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


4-4: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


8-8: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


12-12: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


18-18: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


13-13: null
Bare URL used

(MD034, no-bare-urls)


Line range hint 87-1028: Historical overview of major changes from version 7.0.0 to 9.3.15

This extensive changelog section provides valuable insights into the evolution of the Prowide Core library:

  1. Major version milestones:

    • 7.0.0: Introduced MX message support, new meta-data model, and complete MT helper classes.
    • 8.0.0: Increased JRE requirement to Java 1.8 and implemented SWIFT Standard release update 2019.
    • 9.0.0: (Not explicitly mentioned, but implied by the version numbering)
  2. Continuous improvement in SWIFT standards support:

    • Regular updates to align with annual SWIFT Standard releases.
    • Ongoing additions and refinements to MT and MX message types and fields.
  3. API enhancements:

    • Introduction of builder patterns, fluent APIs, and more intuitive interfaces.
    • Addition of JSON and XML serialization/deserialization capabilities.
  4. Performance and security:

    • Various optimizations and bug fixes throughout the versions.
    • Security improvements, including better handling of XML parsing.
  5. Modernization:

    • Gradual increase in Java version requirements.
    • Updates to third-party dependencies.
  6. Documentation and usability:

    • Improvements in JavaDoc and code examples.
    • Enhanced error messages and logging.

This historical overview showcases the library's commitment to staying current with SWIFT standards while continuously improving its API, performance, and feature set.

🧰 Tools
🪛 LanguageTool

[typographical] ~17-~17: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...ncy update: gson -> 2.11.0' #### 9.4.16 - May 2024 * (PW-1862) Added NarrativeFr...

(DASH_RULE)

🪛 Markdownlint

3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


5-5: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


8-8: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


9-9: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


12-12: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


13-13: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


14-14: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


15-15: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


18-18: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


7-7: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


11-11: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


17-17: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


4-4: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


8-8: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


12-12: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


18-18: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


13-13: null
Bare URL used

(MD034, no-bare-urls)


Line range hint 1-1028: Comprehensive and well-maintained changelog

This CHANGELOG.md file is an excellent example of a well-maintained, comprehensive changelog that provides valuable information to users and developers:

  1. Consistent structure: Each version is clearly labeled with its number and release date, followed by a bulleted list of changes.
  2. Detailed descriptions: Changes are described with sufficient detail, often including issue numbers or specific field/MT references.
  3. Wide coverage: The changelog covers an extensive period, from version 7.0.0 to the current 9.5.2 SNAPSHOT, allowing users to track the library's evolution.
  4. Balance of information: It includes a good mix of new features, improvements, bug fixes, and standard compliance updates.
  5. Transparency: The changelog clearly indicates when breaking changes or deprecations occur, helping users plan for upgrades.

Overall, this changelog serves as a valuable resource for understanding the library's development history, planning upgrades, and appreciating the ongoing efforts to improve and maintain the Prowide Core library.

🧰 Tools
🪛 LanguageTool

[typographical] ~17-~17: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...ncy update: gson -> 2.11.0' #### 9.4.16 - May 2024 * (PW-1862) Added NarrativeFr...

(DASH_RULE)

🪛 Markdownlint

3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


5-5: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


8-8: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


9-9: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


12-12: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


13-13: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


14-14: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


15-15: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


18-18: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


7-7: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


11-11: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


17-17: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


4-4: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


8-8: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


12-12: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


18-18: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


13-13: null
Bare URL used

(MD034, no-bare-urls)

@@ -34,6 +34,7 @@ scmVersion {
}
}
project.version = "${SRU}-${scmVersion.version}"
//project.version = "${SRU}-9.5.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Consider removing the commented-out version override

This commented-out line doesn't affect the build but might lead to confusion. If it's no longer needed for version overrides, consider removing it to keep the build file clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants